Re: [PATCH] NETIF_F_LLTX for devices 2

[Jeff Garzik <jgarzik@xxxxxxxxx>]

On Sun, Sep 12, 2004 at 12:25:29PM +0200, Andi Kleen wrote:
> On Sun, Sep 12, 2004 at 06:01:14AM -0400, Jeff Garzik wrote:
> > 
> > Oh and update Documentation/networking/netdevice.txt.
> > 
> > If people are going to screw with the TX path, at least do it right and
> > make it non-mysterious for everyone else.
> > 
> > See Al Viro's Documentation/filesystem/directory-locking doc for a
> > proper way to document a locking change that potentially affects every
> > net driver in the kernel.
> 
> <broken record mode>
> No it doesn't. It only affects every driver who sets NETIF_F_LLTX.
> For drivers that don't set this flag there is no change at all. 
> </record>

Incorrect, you are changing the callsites, which -does- affect every
driver.


> I wasn't aware of Documentation/netdevices.txt, but I agree it 
> would be a good idea to update it. Patch for that attached.
> DaveM, please apply.

Thanks, but still need a patch for return value constants, otherwise you
are compounding rather than addressing a current problem.

        Jeff