On Sat, 2004-09-11 at 10:21, Andi Kleen wrote:
> On Fri, Sep 10, 2004 at 09:33:35AM -0400, jamal wrote:
> > I am not 100% happy but let me do some testing on it. Would the best
> > image be the latest bk snapshot?
> What exactly are you not happy about?
Grr, Andi, Did you really have to force me to explain why i am unhappy?
As a general principle i think it is against human nature to be happy.
In this specific case, though:
Remember that famous movie breakup line "its just me not you"?
Well, this is along those lines;-> I am not as conservative as say
Donald Becker, but it worries me messing with code that might have
repurcassions (as innocent as that code seems). It doesnt help that
recently theres more breakages in the netsched code than there have been
in the last few years put together.
If Alexey(who knows that piece of code better than anybody) was awake
and he ACKed i wouldnt be commenting.
Having said that, when i saw your patch with the comment:
/* hard_start_xmit returns:
0 device not ready
1 everything ok
-1 didn't get device lock (for LLTX)
my mythical level of unhapiness went up;->
Clearly for 0 and 1 your comments are misleading/wrong (even though your
code does the right thing).
If i was the one who had thought of the need for this new lock-riddance
then i would have done it as follows:
- have a devices xmit_lock as an alias to this other lock in case of
Then you wouldnt have to touch this code. Infact if it is not too late
why not do it like that?
To add to all this, theres well known semantics of what the return code
-> 0 means the packet was swallowed by driver.
-> 1 means packet was not swallowed.
I dont know why you would need to introduce a new return code.
All the device is saying is "sorry, I am busy, come back later". Infact
in the pre-softnet days the flag was called precisely "tbusy".
Now, it would make a lot of sense to introduce new return code if you
actually have plans to use it. You probably do but havent stated it. Do
you have plans to use that return code?
Does that explain my unhappiness? ;-> Does that make you happy? ;->
Now i need to refill my coffee.