netdev
[Top] [All Lists]

Re: [PATCH] Compat32 setsockopt overzealous conversions

To: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Compat32 setsockopt overzealous conversions
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 10 Sep 2004 16:43:54 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <1094716398.15909.27.camel@xxxxxxxxxxxxxxxxxxxxx>
References: <1094563381.5122.8.camel@xxxxxxxxxxxxxxxxxxxxx> <20040907140649.42eaa278.davem@xxxxxxxxxxxxx> <1094716398.15909.27.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 09 Sep 2004 08:53:18 +0100
David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:

2.4.x patch applied, thanks David.

> Back in the real world of 2.6, we REALLY do need to stop trying to do
> all this in a sockopt syscall wrapper, and instead pass down a 32/64 bit
> flag to the code which actually handles the sockopt -- although the
> optlen ought to be sufficient for the _majority_ of cases. Or maybe we
> should handle it like we do ioctls? 

That latter idea (doing it like ioctls) is an option, and in
fact I like it since it would allow us to push the complicated
netfilter translators into the netfilter code.

<Prev in Thread] Current Thread [Next in Thread>