Re: Bad: scheduling while atomic! in 2.6.8.1

["David S. Miller" <davem@xxxxxxxxxxxxx>]

On Wed, 8 Sep 2004 23:42:37 +0200
Wolfgang Walter <wolfgang.walter@xxxxxxxxxxxxxxxxxxxx> wrote:

> We see the exactly the same with 2.6.8.1.
> 
> Our host has 3 nics (all 3 are intel e100). We are using vlan, iptables (no 
> nat or connection tracking, though) and ipsec. We tested it on other hardware 
> (different mainboard, different nics) and the problem remains.
> 
> We are getting the log for every received packet, doesn't matter if these are 
> dhcp-requests, pings or something else.

You have CONFIG_PREEMPT enabled don't you?

This should fix it, it's a bug in Stephen's conversion of the VLAN
code over to use RCU locking.

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/09/08 21:07:49-07:00 davem@xxxxxxxxxxxxxxxxxx 
#   [VLAN]: Fix thinko in RCU locking.
#   
#   Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
# 
# net/8021q/vlan_dev.c
#   2004/09/08 21:07:19-07:00 davem@xxxxxxxxxxxxxxxxxx +1 -1
#   [VLAN]: Fix thinko in RCU locking.
# 
diff -Nru a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
--- a/net/8021q/vlan_dev.c      2004-09-08 21:08:30 -07:00
+++ b/net/8021q/vlan_dev.c      2004-09-08 21:08:30 -07:00
@@ -244,7 +244,7 @@
                        /* TODO:  Add a more specific counter here. */
                        stats->rx_errors++;
                }
-               rcu_read_lock();
+               rcu_read_unlock();
                return 0;
        }