netdev
[Top] [All Lists]

Re: [PATCH 2.6] ipconfig accepts any DHCPACK

To: Joe Perches <joe@xxxxxxxxxxx>
Subject: Re: [PATCH 2.6] ipconfig accepts any DHCPACK
From: Peter Buckingham <peter@xxxxxxxxxxxx>
Date: Tue, 07 Sep 2004 17:18:17 -0700
Cc: David S Miller <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <1094602330.3076.2.camel@xxxxxxxxxxxxxxxxxxxxx>
References: <413E2C26.5040108@xxxxxxxxxxxx> <20040907150204.119ba849.davem@xxxxxxxxxx> <413E39F2.4070708@xxxxxxxxxxxx> <1094602330.3076.2.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040820 Debian/1.7.2-4
Joe Perches wrote:
        if (memcmp(dev->dev_addr, b->hw_addr, dev->addr_len)!=0)
                goto drop_unlock;


I prefer this one.

Signed-off-by: Peter Buckingham <peter@xxxxxxxxxxxx>

--- linus-2.6/net/ipv4/ipconfig.c       2004-09-02 14:53:54.000000000 -0700
+++ local_linux/net/ipv4/ipconfig.c     2004-09-07 17:16:55.000000000 -0700
@@ -966,6 +966,9 @@ static int __init ic_bootp_recv(struct s
                                break;

                        case DHCPACK:
+                               if (memcmp(dev->dev_addr, b->hw_addr, 
dev->addr_len) != 0)
+                                       goto drop_unlock;
+
                                /* Yeah! */
                                break;



<Prev in Thread] Current Thread [Next in Thread>