netdev
[Top] [All Lists]

Re: bad TSO performance in 2.6.9-rc2-BK

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: bad TSO performance in 2.6.9-rc2-BK
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 30 Sep 2004 15:47:38 +1000
Cc: ak@xxxxxxx, niv@xxxxxxxxxx, jheffner@xxxxxxx, andy.grover@xxxxxxxxx, anton@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040929213310.40f5f33a.davem@davemloft.net>
References: <Pine.NEB.4.33.0409291648560.3434-100000@dexter.psc.edu> <415B24C0.2020208@us.ibm.com> <20040929145050.71afa1ac.davem@davemloft.net> <20040929215613.GC26714@wotan.suse.de> <20040929162923.796d142e.davem@davemloft.net> <20040930000515.GA10496@gondor.apana.org.au> <20040929213310.40f5f33a.davem@davemloft.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Wed, Sep 29, 2004 at 09:33:10PM -0700, David S. Miller wrote:
>
> @@ -2413,7 +2410,7 @@
>                                                       packets_acked);
>                       if (sacked & TCPCB_URG) {
>                               if (tp->urg_mode &&
> -                                 !before(scb->seq, tp->snd_up))
> +                                 !before(orig_seq, tp->snd_up))
>                                       tp->urg_mode = 0;

That looks like a typo.  We should check against the new starting
sequence number, not the original.  We should also change the !before
to after since the original check applied to end_seq.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>