netdev
[Top] [All Lists]

Re: bad TSO performance in 2.6.9-rc2-BK

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: bad TSO performance in 2.6.9-rc2-BK
From: Nivedita Singhvi <niv@xxxxxxxxxx>
Date: Mon, 27 Sep 2004 23:45:44 -0700
Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, jheffner@xxxxxxx, ak@xxxxxxx, andy.grover@xxxxxxxxx, anton@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040927215901.6f65dc15.davem@davemloft.net>
References: <20040923161141.4ea9be4c.davem@davemloft.net> <Pine.NEB.4.33.0409271416360.14606-100000@dexter.psc.edu> <20040927160411.22b44f48.davem@davemloft.net> <20040927233639.GA8333@gondor.apana.org.au> <20040927171356.6a59d039.davem@davemloft.net> <20040928003412.GA8755@gondor.apana.org.au> <20040927215901.6f65dc15.davem@davemloft.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.1) Gecko/20040707
David S. Miller wrote:

It's got a nasty bug though, I'm not updating
TCP_SKB_CB(skb)->seq so retransmits have corrupted
sequence numbers, doh!  And hey if I update that
then I do not need this tso_offset thingy.

Hmm, I got sidetracked by seeing corrupted sequence numbers in my tcpdump traces from before, although that shouldn't have been the case..(sorry, don't have access to boxes at the moment, will post it tmrw). Was seeing the sequence numbers go backwards (simple scp testing, bk10)..

Will redo testing in the morning on latest patches...

thanks,
Nivedita

<Prev in Thread] Current Thread [Next in Thread>