netdev
[Top] [All Lists]

Re: [TCP] Fixed mss in tcp_init_cwnd

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [TCP] Fixed mss in tcp_init_cwnd
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 27 Sep 2004 16:04:54 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040927220240.GA7633@gondor.apana.org.au>
References: <20040927080828.GA12056@gondor.apana.org.au> <20040927120031.55fb4a49.davem@davemloft.net> <20040927220240.GA7633@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 28 Sep 2004 08:02:40 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, Sep 27, 2004 at 12:00:31PM -0700, David S. Miller wrote:
> > On Mon, 27 Sep 2004 18:08:28 +1000
> > Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> > 
> > > The MSS in tcp_init_cwnd should be the real one instead of the TSO value.
> > 
> > This happens too early in the connections lifetime
> > to make a difference for anything.
> 
> I know.  That's why I put it in a different thread.
> 
> IMHO we should still fix it though at least for consistency.

That early on in the connection, it should be setting both
values, right?  If so your patch still needs a tweak. :)

<Prev in Thread] Current Thread [Next in Thread>