netdev
[Top] [All Lists]

Re: Patch submission for S2io Xframe driver to 2.6 kernel

To: <ravinandan.arakali@xxxxxxxx>
Subject: Re: Patch submission for S2io Xframe driver to 2.6 kernel
From: "Randy.Dunlap" <rddunlap@xxxxxxxx>
Date: Thu, 16 Sep 2004 20:58:49 -0700
Cc: jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, leonid.grossman@xxxxxxxx, raghavendra.koushik@xxxxxxxx, rapuru.sriram@xxxxxxxx
In-reply-to: <002201c499b4$7c7b60c0$a010100a@S2IOtech.com>
Organization: OSDL
References: <413116FF.7000701@pobox.com> <002201c499b4$7c7b60c0$a010100a@S2IOtech.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 13 Sep 2004 10:09:53 -0700 Ravinandan Arakali wrote:

| Hi Jeff,
| Attached is the patch with the first round comments incorporated.
| In addition, this patch contains
| Some fixes related to 32-bit systems.
| Few fixes related to Rx path in NAPI.
| 
| Thanks to all for the comments.
| 
| Pls review this patch as well and come back with your comments.


1.  typo?  first name is still used in source code:

-static char s2io_driver_version[] = "Version 1.0";
+static char s2iO_driver_version[] = "Version 1.1";

2.  don't init. globals to 0 -- it's done automatically for you.


(more this weekend....)

--
~Randy

<Prev in Thread] Current Thread [Next in Thread>