netdev
[Top] [All Lists]

Re: 2.6.9-rc1-mm5: TCP oopses

To: davem@xxxxxxxxxxxxx (David S. Miller)
Subject: Re: 2.6.9-rc1-mm5: TCP oopses
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 14 Sep 2004 13:34:20 +1000
Cc: jmorris@xxxxxxxxxx, akpm@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040913190858.12544431.davem@davemloft.net>
Organization: Core
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.26-1-686-smp (i686))
David S. Miller <davem@xxxxxxxxxxxxx> wrote:
>
> @@ -968,11 +972,17 @@
>                return -EAGAIN;
> 
>        if (skb->len > cur_mss) {
> +               int old_factor = TCP_SKB_CB(skb)->tso_factor;
> +               int new_factor;
> +
>                if (tcp_fragment(sk, skb, cur_mss))
>                        return -ENOMEM; /* We'll try again later. */
> 
>                /* New SKB created, account for it. */
> -               tcp_inc_pcount(&tp->packets_out, skb);
> +               new_factor = TCP_SKB_CB(skb)->tso_factor;
> +               tcp_dec_pcount_explicit(&tp->packets_out,
> +                                       new_factor - old_factor);

That should be tcp_inc_pcount_explicit.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>