netdev
[Top] [All Lists]

Re: [PATCH] [RFC] Support for wccp version 1 and 2 in ip_gre.c

To: Paul P Komkoff Jr <i@xxxxxxxxxx>
Subject: Re: [PATCH] [RFC] Support for wccp version 1 and 2 in ip_gre.c
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 13 Sep 2004 16:19:12 -0700
Cc: i@xxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20040913051706.GB26337@stingr.sgu.ru>
References: <20040911194108.GS28258@stingr.sgu.ru> <20040912170505.62916147.davem@davemloft.net> <20040913051706.GB26337@stingr.sgu.ru>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 13 Sep 2004 09:17:06 +0400
Paul P Komkoff Jr <i@xxxxxxxxxx> wrote:

> Replying to David S. Miller:
> > What are the rules for IP_GRE in general for when
> > to apply this transformation?
> 
> As you can see, I am applying it unconditionally when fits. For most
> cases, this will be OK.
> There can be situations when this is not wanted (for example, when 
> debugging something), so in general, tuning knob will be useful, but 
> I just don't know where to add it, maybe tunnel->parms.i_flags ...

I don't think adding such a knob is necessary, but yes i_flags
would be the place to do it.

I will apply your patch with the "if(1)" simply removed.

Thanks.

<Prev in Thread] Current Thread [Next in Thread>