netdev
[Top] [All Lists]

Re: RFC/PATCH capture qdisc requeue event in stats

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: RFC/PATCH capture qdisc requeue event in stats
From: jamal <hadi@xxxxxxxxxx>
Date: 30 Aug 2004 18:14:48 -0400
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040830144033.2265a6e6.davem@xxxxxxxxxx>
Organization: jamalopolous
References: <1093799632.1073.410.camel@xxxxxxxxxxxxxxxx> <20040830144033.2265a6e6.davem@xxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 2004-08-30 at 17:40, David S. Miller wrote:
> On 29 Aug 2004 13:13:52 -0400
> jamal <hadi@xxxxxxxxxx> wrote:
> 
> > Opinions welcome - If all is good, Dave please apply.
> 
> tc_stats changes size, how will existing applications cope?
> Since it is just RTA_PUT() into userspace, will that just work
> or will existing apps bomb because they'll do a check of the
> size field of the rtnetlink attribute?

To look at an existing app such as tc; attached is a patch.
In the tc case. The possibilities are:

1) old kernels + old tc --> should work 
2) new kernels + old tc --> should work
3) new kernels + new tc --> should work
4) old kernel +  new tc --> will bomb (sizeof check will fail)

Cant think of something smart to do with option #4. I have contemplated
playing with offsetoff() etc. The best thing i can think of right
now is to complain about it as in that fprintf()

Thoughts?

cheers,
jamal

Attachment: reqs-patch-iproute2-2.6.8
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>