netdev
[Top] [All Lists]

Re: [PATCH] allow setting mtu and txqlen via RTM_SETLINK and provide txq

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH] allow setting mtu and txqlen via RTM_SETLINK and provide txqlen via RTM_GETLINK
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Tue, 24 Aug 2004 17:34:37 -0700
Cc: herbert@xxxxxxxxxxxxxxxxxxx, kuznet@xxxxxxxxxxxxx, hadi@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040824180825.GJ21296@xxxxxxxxxxxxxx>
References: <20040824094952.GF21073@xxxxxxxxxxxxxx> <E1BzYMJ-000208-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20040824162501.GI21296@xxxxxxxxxxxxxx> <20040824103252.1b593e68.davem@xxxxxxxxxx> <20040824180825.GJ21296@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 24 Aug 2004 20:08:25 +0200
Thomas Graf <tgraf@xxxxxxx> wrote:

> --- 1.33/include/linux/rtnetlink.h    Mon Apr  5 23:41:40 2004
> +++ 1.35/include/linux/rtnetlink.h    Tue Aug 24 20:06:53 2004
> @@ -540,6 +540,8 @@
>       IFLA_QDISC,
>       IFLA_STATS,
>       IFLA_COST,
> +     IFLA_TXQLEN,
> +     IFLA_MAP,
>  #define IFLA_COST IFLA_COST
>       IFLA_PRIORITY,
>  #define IFLA_PRIORITY IFLA_PRIORITY

You cannot add new IFLA_* numbers to the middle of the
enumeration, that changes the subsequent existing
IFLA_* values which are hard-coded in userspace applications.

I've fixed this and applied your patch, thanks Thomas.

Could you please provide a 2.4.x version?

<Prev in Thread] Current Thread [Next in Thread>