netdev
[Top] [All Lists]

Re: [PATCH] allow setting mtu and txqlen via RTM_SETLINK and provide txq

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] allow setting mtu and txqlen via RTM_SETLINK and provide txqlen via RTM_GETLINK
From: Thomas Graf <tgraf@xxxxxxx>
Date: Tue, 24 Aug 2004 14:04:42 +0200
Cc: davem@xxxxxxxxxx, kuznet@xxxxxxxxxxxxx, hadi@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <E1BzYMJ-000208-00@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20040824094952.GF21073@xxxxxxxxxxxxxx> <E1BzYMJ-000208-00@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
* Herbert Xu <E1BzYMJ-000208-00@xxxxxxxxxxxxxxxxxxxxxxxx> 2004-08-24 20:16
> Please think about the meaning of the value.  Is anyone going to have a queue
> bigger than 2^32?
> 
> And if the answer is yes, then please use u64.

Can you please explain the actual reason for using a fixed width
type when all existing numeric attributes use arch depedent types?

I agree with you, if it happens to be the reason, that it is easier for a
userspace application to use fixed width types but we should change
it for all attributes if the decision is made for this one.

I have more patches in my queue which would throw up the same question
again. Therefore I'd like to see it discussed now and a decision to be
made whether to use fixed width types or not.

   Thomas

<Prev in Thread] Current Thread [Next in Thread>