| To: | "David S. Miller" <davem@xxxxxxxxxx>, jmorris@xxxxxxxxxx, netdev@xxxxxxxxxxx |
|---|---|
| Subject: | RFC: pskb_expand_head instead of skb_copy in skb_checksum_help |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Tue, 24 Aug 2004 21:05:32 +1000 |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040722i |
Hi: Here is the patch that you wanted to shoot holes at :) The idea is simple. None of the callers of skb_checksum are passing it skb's which are shared. They may be cloned however. But the application checksum is always in the skb header so there is no need to linearise it. Supposing all these assumptions are correct, then we can avoid the overhead of skb_copy() and get away with pskb_expand_head(). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [IPSEC] Set TTL from route, Herbert Xu |
|---|---|
| Next by Date: | Re: [PATCH] allow setting mtu and txqlen via RTM_SETLINK and provide txqlen via RTM_GETLINK, Thomas Graf |
| Previous by Thread: | [IPSEC] Set TTL from route, Herbert Xu |
| Next by Thread: | Re: RFC: pskb_expand_head instead of skb_copy in skb_checksum_help, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |