On Thu, Aug 19, 2004 at 07:17:50AM -0700, David S. Miller wrote:
> On Thu, 19 Aug 2004 11:44:01 +0200
> Harald Welte <laforge@xxxxxxxxxxxxx> wrote:
>
> > http://lists.netfilter.org/pipermail/netfilter-devel/2004-August/016277.html
>
> I totally disagree with this change.
Ok, that's fine with me. Let's stay with the skb_header_pointer(),
which by the way [as expected] is not visible on my profile runs.
Still, I am curious to know if anyone on one of the Cc'ed mailinglists
can imagine a case where parts of the header up and including the tcp
options could be non-linear.
And no, I do not want to know this in order to say that
skb_heder_pointer() is bad. I just want to know, because then we might
still need some magic for those cases in order to avoid a case where we
end up with per-rule copies or similar stuff again.
Thanks!
--
- Harald Welte <laforge@xxxxxxxxxxxxx> http://www.netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie
signature.asc
Description: Digital signature
|