Re: [PATCH 2.6.8] ipvs - do not use skb_checksum_help

[Julian Anastasov <ja@xxxxxx>]

        Hello,

On Tue, 17 Aug 2004, James Morris wrote:

> On Tue, 17 Aug 2004, Wensong Zhang wrote:
>
> > Agree with Julian that there is no need to call skb_checksum_help in IPVS.
>
> What if you have a cloned skb?  It needs to be copied.

        No problem, there is already ip_vs_make_skb_writable() which 
properly handles such skb states. It is used in lots of places in ipvs/:

root@b:/usr/src/linux-2.6.8.1# grep -r ip_vs_make_skb_writable 
net/ipv4/ipvs/|wc -l
14

        For read access skb_copy_bits() is used:

root@b:/usr/src/linux-2.6.8.1# grep -r skb_copy_bits net/ipv4/ipvs/|wc -l
23

> - James

Regards

--
Julian Anastasov <ja@xxxxxx>