netdev
[Top] [All Lists]

Re: [PATCH] Move inetdev/ifa over to RCU

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] Move inetdev/ifa over to RCU
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 16 Aug 2004 13:14:56 +1000
Cc: shemminger@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040815200838.1f971350.davem@xxxxxxxxxx>
References: <20040813151923.3311b4f0.davem@xxxxxxxxxx> <20040814003428.GA17760@xxxxxxxxxxxxxxxxxxx> <20040813173924.6d05be15.davem@xxxxxxxxxx> <20040814005411.GA18350@xxxxxxxxxxxxxxxxxxx> <20040814012513.GA721@xxxxxxxxxxxxxxxxxxx> <20040814013030.GA2042@xxxxxxxxxxxxxxxxxxx> <20040814050848.GA11874@xxxxxxxxxxxxxxxxxxx> <20040815190823.654bf2d5.davem@xxxxxxxxxx> <20040816024329.GA8127@xxxxxxxxxxxxxxxxxxx> <20040815200838.1f971350.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040523i
On Sun, Aug 15, 2004 at 08:08:38PM -0700, David S. Miller wrote:
> On Mon, 16 Aug 2004 12:43:30 +1000
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > It will return zero if there is no in_dev at all.  Perhaps what
> > we should do is get inet_select_addr() to get the address from
> > other devices in that case as well?
> 
> It does that now, look at how it iterates over dev_base's
> list.

But not if __in_dev_get() == NULL.  The following patch should
express that more clearly.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>