netdev
[Top] [All Lists]

Re: [PATCH] Move inetdev/ifa over to RCU

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] Move inetdev/ifa over to RCU
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 16 Aug 2004 12:43:30 +1000
Cc: shemminger@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040815190823.654bf2d5.davem@xxxxxxxxxx>
References: <20040813093838.6961c0d4.davem@xxxxxxxxxx> <20040813215602.GA15870@xxxxxxxxxxxxxxxxxxx> <20040813151923.3311b4f0.davem@xxxxxxxxxx> <20040814003428.GA17760@xxxxxxxxxxxxxxxxxxx> <20040813173924.6d05be15.davem@xxxxxxxxxx> <20040814005411.GA18350@xxxxxxxxxxxxxxxxxxx> <20040814012513.GA721@xxxxxxxxxxxxxxxxxxx> <20040814013030.GA2042@xxxxxxxxxxxxxxxxxxx> <20040814050848.GA11874@xxxxxxxxxxxxxxxxxxx> <20040815190823.654bf2d5.davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040523i
On Sun, Aug 15, 2004 at 07:08:23PM -0700, David S. Miller wrote:
>
> > Do we really care about the zero return value of inet_select_addr()
> > here? What about the other calls to inet_select_addr()?
> 
> It won't return zero, typically it will return loopback's IP
> (with preference to any non-loopback addresses assigned to
>  the loopback device).  This is being used for source address
> selection.

It will return zero if there is no in_dev at all.  Perhaps what
we should do is get inet_select_addr() to get the address from
other devices in that case as well?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>