netdev
[Top] [All Lists]

Re: [Prism54-devel] Re: [PATCH/RFC] set_rates support for prism54

To: margitsw@xxxxxxxxxxx (Margit Schubert-While), prism54-devel@xxxxxxxxxxx
Subject: Re: [Prism54-devel] Re: [PATCH/RFC] set_rates support for prism54
From: Denis Vlasenko <vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 15 Aug 2004 19:10:25 +0300
Cc: mcgrof@xxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx
In-reply-to: <5.1.0.14.2.20040815145122.00afd708@xxxxxxxxxxxxxxx>
References: <5.1.0.14.2.20040815145122.00afd708@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.5.4
On Sunday 15 August 2004 16:21, Margit Schubert-While wrote:
> I disagree with this.
> We don't need parameter parsing either in the driver or in
> wireless.c.
> There is a perfectly good infrastructure in wireless tools iwpriv.c
> Take a look at around line 375 in iwpriv.c for the
> existing example of IW_PRIV_TYPE_FLOAT.
> This could be adapted for this purpose (IW_PRIV_TYPE_BITRATE ?)
> and (mis)use the iw_freq structure to pass the values and extra info.

Ok. And then we will need to parse that data into format suitable for
prism54 in prism54 driver, and into format suitable for acx100/acx111
in acx100 driver, etc... Most probably this code will be ugly, because
different hardware have completely different way of setting tx rate.
Even acx100 and acx111 are different, not to say acx100 and prism54.
--
vda


<Prev in Thread] Current Thread [Next in Thread>