| To: | Francois Romieu <romieu@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2.6.8-rc3-mm1 1/2] 8139too: Rx fifo/overflow recovery |
| From: | Jeff Garzik <jgarzik@xxxxxxxxx> |
| Date: | Wed, 11 Aug 2004 18:56:46 -0400 |
| Cc: | Andrew Morton <akpm@xxxxxxxx>, Pasi Sjoholm <ptsjohol@xxxxxxxxx>, Hector Martin <hector@xxxxxxxxxxxxxx>, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <20040811223243.GA8584@xxxxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20040805234336.A15407@xxxxxxxxxxxxxxxxxxxxxxxxxx> <411A70CB.8060101@xxxxxxxxx> <20040811223243.GA8584@xxxxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510 |
Francois Romieu wrote: Jeff Garzik <jgarzik@xxxxxxxxx> : [...]You _want_ to update those registers on every packet. Otherwise the crappy 8139 chip breaks.The affected users noticed a clear difference when the update was in the no-packet branch instead of the packet processing loop. Btw the excerpt of the documentation outlined by Hirofumi san suggests that this update makes sense. Any objection/suggestion regarding a patch which would allow the update in both branches ? Both branches is fine.You'll quickly hit the RX-error-requiring-reset condition if you don't update on each packet, though.
Jeff
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 2.6: rxrpc compile errors with SYSCTL=n, Adrian Bunk |
|---|---|
| Next by Date: | Re: net-AIO and real-time TCP (blue sky research), Werner Almesberger |
| Previous by Thread: | Re: [PATCH 2.6.8-rc3-mm1 1/2] 8139too: Rx fifo/overflow recovery, Francois Romieu |
| Next by Thread: | Re: [PATCH 2.6.8-rc3-mm1 1/2] 8139too: Rx fifo/overflow recovery, Francois Romieu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |