[Top] [All Lists]

Re: [PATCH 2.6] (1/3) add ethtool ioctl forwarding to vlan

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH 2.6] (1/3) add ethtool ioctl forwarding to vlan
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 4 Aug 2004 09:56:40 -0700
Cc: greearb@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040803105017.0774e1db@xxxxxxxxxxxxxxxxxxxxx>
References: <20040803105017.0774e1db@xxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 3 Aug 2004 10:50:17 -0700
Stephen Hemminger <shemminger@xxxxxxxx> wrote:

> When network devices are used in bridges, the bridge does an ethtool
> ioctl to pick up the speed; this doesn't work with vlans.
> This patch makes any ethtool gets forwarded to the under lying
> real device.  It seemed to make sense to do MII as well.

By changing the ifr.ifr_name field, you are going to corrupt
the return value the user will see if ':' "colon" processing
is done by dev_ioctl().

An ifreq isn't too large, just use a local copy on
vlan_dev_ioctl()'s stack.

<Prev in Thread] Current Thread [Next in Thread>