netdev
[Top] [All Lists]

Re: [PATCH] Prevent crash on ip_conntrack removal

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH] Prevent crash on ip_conntrack removal
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Sun, 29 Aug 2004 16:38:21 -0700
Cc: dlstevens@xxxxxxxxxx, davem@xxxxxxxxxx, laforge@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, netdev-bounce@xxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxxxxxx, okir@xxxxxxx
In-reply-to: <4132516E.7080805@trash.net>
References: <412A8FB5.4080700@trash.net> <OFE08A3DF5.09BCA1C4-ON88256EFA.00806C05-88256EFA.0080E98F@us.ibm.com> <20040828231529.051a73cc.davem@davemloft.net> <4132303C.2060807@trash.net> <20040829125708.5aa70469.davem@davemloft.net> <4132516E.7080805@trash.net>
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 29 Aug 2004 23:58:06 +0200
Patrick McHardy <kaber@xxxxxxxxx> wrote:

> Before I post the patch, 2.4 seems to be
> missing this patch, do you already have it queued or should I send
> a 2.4 version first ?
> 
> ChangeSet@xxxxxx, 2004-08-18 14:28:05-07:00, davem@xxxxxxxxxxxxxxxxxx
>   [IPV4]: Fix theoretical loop on SMP in ip_evictor().

I pushed this off to Marcelo, he just didn't pull from my
tree yet, which is at:

        bk://kernel.bkbits.net/davem/net-2.4

Where you'll find those fixes as:

ChangeSet@xxxxxxxxxx, 2004-08-18 14:26:09-07:00, davem@xxxxxxxxxxxxxxxxxx
  [IPV4]: Fix theoretical loop on SMP in ip_evictor().
  
  Snapshot the amount of work to do, and just do it.
  In this way we avoid a theoretical loop whereby
  one cpu sits in ip_evictor() tossing fragments
  while another keeps adding a fragment just as we
  bring ip_frag_mem  down below the low threshold.
  
  Signed-off-by: David S. Miller <davem@xxxxxxxxxx>

ChangeSet@xxxxxxxxxx, 2004-08-18 14:31:35-07:00, davem@xxxxxxxxxxxxxxxxxx
  [IPV6]: ip6_evictor() has same problem as ip_evictor().
  
  Signed-off-by: David S. Miller <davem@xxxxxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>