netdev
[Top] [All Lists]

Re: [PATCH]Fix adding SA through netlink(xfrm_user)

To: Masahide Nakamura <nakam@xxxxxxxxxxxxxx>
Subject: Re: [PATCH]Fix adding SA through netlink(xfrm_user)
From: James Morris <jmorris@xxxxxxxxxx>
Date: Wed, 28 Jul 2004 11:41:33 -0400 (EDT)
Cc: "David S. Miller" <davem@xxxxxxxxxx>, <netdev@xxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <20040729001058.48cd1791@localhost>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 29 Jul 2004, Masahide Nakamura wrote:

> Hello,
> 
> When adding IPsec SA with PF_KEY (pfkey_add()),
> xfrm_probe_algs() is called to make all algorithms valid.
> However, it is missing to call it with netlink (xfrm_user) case and
> it causes xfrm_aalg_get_byname() return NULL even if the name of
> algorithm seems to be correct.

Looks ok, but odd that this has not been picked up before.

> 
> The patch fixes it and is against 2.6.7. Please apply it.
> 
> Index: linux26/net/xfrm/xfrm_user.c
> ===================================================================
> RCS file: /cvsroot/usagi/usagi/kernel/linux26/net/xfrm/xfrm_user.c,v
> retrieving revision 1.1.1.13
> diff -u -r1.1.1.13 xfrm_user.c
> --- linux26/net/xfrm/xfrm_user.c      3 Apr 2004 05:52:43 -0000       1.1.1.13
> +++ linux26/net/xfrm/xfrm_user.c      28 Jul 2004 14:26:21 -0000
> @@ -258,6 +258,8 @@
>       if (err)
>               return err;
>  
> +     xfrm_probe_algs();
> +
>       x = xfrm_state_construct(p, (struct rtattr **) xfrma, &err);
>       if (!x)
>               return err;
> 
> 
> 
> 

-- 
James Morris
<jmorris@xxxxxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>