| To: | Patrick McHardy <kaber@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2.6]: Make packet scheduler clock source configurable |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Wed, 21 Jul 2004 14:31:10 -0700 |
| Cc: | shemminger@xxxxxxxx, netdev@xxxxxxxxxxx, devik@xxxxxx |
| In-reply-to: | <40F4AC8B.40706@xxxxxxxxx> |
| References: | <40F34740.5040100@xxxxxxxxx> <1107.63.170.215.71.1089689716.squirrel@xxxxxxxxxxxx> <20040712205037.573411c0.davem@xxxxxxxxxx> <40F4862D.3070802@xxxxxxxxx> <40F4AC8B.40706@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Wed, 14 Jul 2004 05:46:19 +0200 Patrick McHardy <kaber@xxxxxxxxx> wrote: > This one actually compiles ;). The assembler of PSCHED_GET_TIME is > exactly the same on x86. There are 10 architectures that return > something non-zero for get_cycles(), but I have no idea if it is > suitable on all of them. Patch applies on top of the dead-code > removal patch. This looks great. As you mention some platforms return zero, for example sparc32, for get_cycles(). I suggest we just expand the dependency list for NET_SCH_CLK_TSC to include SPARC64 PPC64 and perhaps some other easy to verify as having a working get_cycles() implementation. I believe that as long as it increments at some rate >= jiffies, the psched calibration will get things into a working state. A lot of patches have been posted in this area and I'm losing track of what to apply first etc. Can you repost your work one change at a time? Thanks. |
| Previous by Date: | Re: [PATCH] [sparse] missing annotation in ipv6 addrconf, David S. Miller |
|---|---|
| Next by Date: | Re: [CRYPTO] Fix stack overrun in crypt(), David S. Miller |
| Previous by Thread: | Re: [PATCH 2.6]: Make packet scheduler clock source configurable, Patrick McHardy |
| Next by Thread: | Re: [PATCH 2.6]: Make packet scheduler clock source configurable, Patrick McHardy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |