| To: | Andi Kleen <ak@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Drop ISA dependencies from IRDA drivers |
| From: | Martin Diehl <lists@xxxxxxxxx> |
| Date: | Fri, 16 Jul 2004 08:33:45 +0200 (CEST) |
| Cc: | Jeff Garzik <jgarzik@xxxxxxxxx>, <netdev@xxxxxxxxxxx>, <irda-users@xxxxxxxxxxxxxxxxxxxxx>, Jean Tourrilhes <jt@xxxxxxxxxx>, <the_nihilant@xxxxxxxxxxxxx>, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx> |
| In-reply-to: | <20040716061913.GB662@xxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Fri, 16 Jul 2004, Andi Kleen wrote: > > According to include/asm-x86_64/dma-mapping.h there is no such override > > for x86-64. Hence the generic implementation is used which Oopses when > > called with dev=NULL in dma_alloc_coherent because it dereferences dev > > unconditionally. > > The old pci_alloc_coherent supported hwdev == NULL under x86-64. > dma_alloc_consistent() should too. I will fix that. Ok, thanks. This sounds like the right solution. I think most/all functions in include/asm-generic/dma-mapping.h are not prepared to accept dev=NULL parameters, so it's a bit more than just dma_alloc_coherent() :-( Martin |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Drop ISA dependencies from IRDA drivers, Martin Diehl |
|---|---|
| Next by Date: | Re: [CRYPTO] Fix stack overrun in crypt(), Herbert Xu |
| Previous by Thread: | Re: [PATCH] Drop ISA dependencies from IRDA drivers, Andi Kleen |
| Next by Thread: | [2.6 patch] net/ipv6/route.c: fix inline compile error, Adrian Bunk |
| Indexes: | [Date] [Thread] [Top] [All Lists] |