| To: | "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx> |
|---|---|
| Subject: | Re: Network device driver probe issues |
| From: | Jeff Garzik <jgarzik@xxxxxxxxx> |
| Date: | Fri, 16 Jul 2004 15:52:58 -0400 |
| Cc: | Jim Keniston <jkenisto@xxxxxxxxxx>, David Dillow <dave@xxxxxxxxxxxxxx>, Anton Blanchard <anton@xxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx>, cramerj <cramerj@xxxxxxxxx>, "Ronciak, John" <john.ronciak@xxxxxxxxx>, jonmason@xxxxxxxxxx |
| In-reply-to: | <468F3FDA28AA87429AD807992E22D07E01CEF1BF@orsmsx408> |
| References: | <468F3FDA28AA87429AD807992E22D07E01CEF1BF@orsmsx408> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040510 |
Venkatesan, Ganesh wrote: We've fixed the e100 to have the same logic as e1000. I like the typhoon driver idea. Unfortunately both are wrong.e1000 should not be using dev_alloc_name(), and patches to add that to e100 will not be accepted. e100 should not be referencing netdev->name until after register_netdev() completes. The typhoon solution is fine with me. Other drivers don't bother and simply use pci_name() during probe. It's up to you as maintainer.
Jeff
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Suggestions with hard lockup on 4 systems, have oops report, bert hubert |
|---|---|
| Next by Date: | TGe overview #1, Vladimir Kondratiev |
| Previous by Thread: | RE: Network device driver probe issues, Venkatesan, Ganesh |
| Next by Thread: | Re: wireless-2.6 queue opened, Jeff Garzik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |