netdev
[Top] [All Lists]

Re: [PATCH] Drop ISA dependencies from IRDA drivers

To: Martin Diehl <lists@xxxxxxxxx>
Subject: Re: [PATCH] Drop ISA dependencies from IRDA drivers
From: Andi Kleen <ak@xxxxxx>
Date: 16 Jul 2004 07:45:50 +0200
Date: Fri, 16 Jul 2004 07:45:50 +0200
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx, irda-users@xxxxxxxxxxxxxxxxxxxxx, jt@xxxxxxxxxx, the_nihilant@xxxxxxxxxxxxx, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <Pine.LNX.4.44.0407160027410.14037-100000@xxxxxxxxxxxxxxxxxxxxxxx>
References: <20040715215552.GA46635@xxxxxx> <Pine.LNX.4.44.0407160027410.14037-100000@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Fri, Jul 16, 2004 at 12:32:44AM +0200, Martin Diehl wrote:
> On 15 Jul 2004, Andi Kleen wrote:
> 
> > Remove wrong ISA dependencies for IRDA drivers.
> > 
> > 
> > diff -u linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig-o 
> > linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig
> > --- linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig-o 2004-07-12 
> > 06:09:05.000000000 +0200
> > +++ linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig   2004-07-15 
> > 18:33:48.000000000 +0200
> > @@ -310,7 +310,7 @@
> >  
> >  config NSC_FIR
> >     tristate "NSC PC87108/PC87338"
> > -   depends on IRDA && ISA
> > +   depends on IRDA
> 
> 
> Admittedly I haven't tried either, but I'm pretty sure this patch will 
> break building those drivers because they are calling irda_setup_dma - 
> which is CONFIG_ISA. Maybe this can be dropped but I don't see what's 
> wrong with !64BIT instead.

Hmm, good point. 

!64BIT is not needed - apparently they are 64bit clean.

The reason I want to drop the CONFIG_ISA depency is that they *should*
be built on x86-64 too. 

-Andi

<Prev in Thread] Current Thread [Next in Thread>