netdev
[Top] [All Lists]

[PATCH] netem missing qdisc destroy

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: [PATCH] netem missing qdisc destroy
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Mon, 12 Jul 2004 10:28:55 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040712101500.4a0babd3@xxxxxxxxxxxxxxxxxxxxx>
Organization: Open Source Development Lab
References: <20040712101500.4a0babd3@xxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
The underlying qdisc was not being properly destroyed, shows up as
assertion failure on device removal.

Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx>

diff -Nru a/net/sched/sch_netem.c b/net/sched/sch_netem.c
--- a/net/sched/sch_netem.c     2004-07-12 10:27:10 -07:00
+++ b/net/sched/sch_netem.c     2004-07-12 10:27:10 -07:00
@@ -806,6 +806,9 @@
        struct netem_sched_data *q = (struct netem_sched_data *)sch->data;
 
        del_timer_sync(&q->timer);
+
+       qdisc_destroy(q->qdisc);
+       q->qdisc = &noop_qdisc;
 }
 
 static int netem_dump(struct Qdisc *sch, struct sk_buff *skb)

<Prev in Thread] Current Thread [Next in Thread>