| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: [2.6 patch] net/hamradio/dmascc: remove inlines |
| From: | Adrian Bunk <bunk@xxxxxxxxx> |
| Date: | Sat, 10 Jul 2004 19:16:28 +0200 |
| Cc: | linux-net@xxxxxxxxxxxxxxx, Netdev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <40F020C7.5010608@xxxxxxxxx> |
| References: | <20040710010414.GX28324@xxxxxxxxx> <40F020C7.5010608@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6i |
On Sat, Jul 10, 2004 at 01:00:55PM -0400, Jeff Garzik wrote:
>...
> It seems like you are going directly against the intent of the author,
> with this patch.
The intend of the author might have been different - but the author
didn't notice that his inlines never had any effect since the ordering
of the functions was wrong.
I could send a patch to reorder the file to get the inlines working, but
I heavily doubt inlining e.g. rx_on would be an improvement.
> Jeff
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: ethernet QoS support?, Vladimir Kondratiev |
|---|---|
| Next by Date: | Re: [IPSEC] Move generic encap code into xfrm4_output, David S. Miller |
| Previous by Thread: | Re: [2.6 patch] net/hamradio/dmascc: remove inlines, Jeff Garzik |
| Next by Thread: | Re: [2.6 patch] net/hamradio/dmascc: remove inlines, Adrian Bunk |
| Indexes: | [Date] [Thread] [Top] [All Lists] |