| To: | "David S. Miller" <davem@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [NATT] Fix uh->len with IP options |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Sat, 10 Jul 2004 11:21:53 +1000 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20040709170502.58a05039.davem@xxxxxxxxxx> |
| References: | <20040709114802.GA13344@xxxxxxxxxxxxxxxxxxx> <20040709170502.58a05039.davem@xxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040523i |
On Fri, Jul 09, 2004 at 05:05:02PM -0700, David S. Miller wrote: > > At first I thought you should be using top_iph to compute the options > length, but now I see why it's correct to be using 'iph'. Mea culpa. This is broken in tunnel mode. My big patch that moves the tunnel code out will fix this since it gets rid of iph altogether. But if you want to hold out on that one for a bit then please make the obvious fix by changing iph to top_iph. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [2.6 patch] net/sunrpc/xprt.c: fix inline problem, Adrian Bunk |
|---|---|
| Next by Date: | [IPCOMP6] Exclude IPCOMP header from props.header_len, Herbert Xu |
| Previous by Thread: | Re: [NATT] Fix uh->len with IP options, David S. Miller |
| Next by Thread: | Limiting frame re-encryption with TCP retries..., James Ketrenos |
| Indexes: | [Date] [Thread] [Top] [All Lists] |