| To: | Stephen Hemminger <shemminger@xxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] fix tcp_default_win_scale. |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Fri, 9 Jul 2004 16:14:12 -0700 |
| Cc: | ahu@xxxxxxx, jamie@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20040707110653.7c49bef1@xxxxxxxxxxxxxxxxxxxxx> |
| References: | <20040629222751.392f0a82.davem@xxxxxxxxxx> <20040630152750.2d01ca51@xxxxxxxxxxxxxxxxxxxxx> <20040630153049.3ca25b76.davem@xxxxxxxxxx> <20040701133738.301b9e46@xxxxxxxxxxxxxxxxxxxxx> <20040701140406.62dfbc2a.davem@xxxxxxxxxx> <20040702013225.GA24707@xxxxxxxxxxxxxxxx> <20040706093503.GA8147@xxxxxxxxxxxxxxx> <20040706114741.1bf98bbe@xxxxxxxxxxxxxxxxxxxxx> <20040706194034.GA11021@xxxxxxxxxxxxxxxxxx> <20040706131235.10b5afa8.davem@xxxxxxxxxx> <20040706224453.GA6694@xxxxxxxxxxxxxxx> <20040706154907.422a6b73.davem@xxxxxxxxxx> <20040707110653.7c49bef1@xxxxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Wed, 7 Jul 2004 11:06:53 -0700 Stephen Hemminger <shemminger@xxxxxxxx> wrote: > But: isn't it better to have just one sysctl parameter set (tcp_rmem) > and set the window scale as needed rather than increasing the already > bewildering array of dials and knobs? I can't see why it would be > advantageous > to set a window scale of 7 if the largest possible window ever offered > is limited to a smaller value? Stephen, here is what is going to happen if we apply your patch. The default window scale will be 2, which is under the value which starts to cause the problems which is 3. So things will silently work, and most people will not notice the problem. I'd much rather bugs scream out saying "I'm a bug fix me!" than to just silently linger around mostly unnoticed. |
| Previous by Date: | Re: ethernet QoS support?, Sam Leffler |
|---|---|
| Next by Date: | Re: [PATCH] mark CSZ scheduler as broken, David S. Miller |
| Previous by Thread: | Re: [PATCH] fix tcp_default_win_scale., John Heffner |
| Next by Thread: | Re: [PATCH] fix tcp_default_win_scale., Nivedita Singhvi |
| Indexes: | [Date] [Thread] [Top] [All Lists] |