netdev
[Top] [All Lists]

bk16 changes to cbq

To: Alexey <kuznet@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>
Subject: bk16 changes to cbq
From: jamal <hadi@xxxxxxxxxx>
Date: 03 Jul 2004 09:36:50 -0400
Cc: Stephen Hemminger <shemminger@xxxxxxxx>, netdev@xxxxxxxxxxx
Organization: jamalopolis
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
I am noticing this in bk16; it may be one of the changes that came 
from Stephen recently..

--- a/net/sched/sch_cbq.c       2004-02-20 18:37:25 -08:00
+++ b/net/sched/sch_cbq.c       2004-06-18 13:51:18 -07:00
@@ -1054,7 +1054,7 @@
 
        if (sch->q.qlen) {
                sch->stats.overlimits++;
-               if (q->wd_expires && !netif_queue_stopped(sch->dev)) {
+               if (q->wd_expires) {
                        long delay = PSCHED_US2JIFFIE(q->wd_expires);
                        if (delay <= 0)
                                delay = 1;

What i remember is this (4-5 years back) used to cure a bug - cant
remember the details unfortunately, but Alexey may remember.
I am hoping removal of the above line implies that those conditions dont
exist anymore? 

At the expense of repeating a discussion that may have already happened,
what was the logic for removing this line?

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>