netdev
[Top] [All Lists]

Re: bk16 changes to cbq

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: bk16 changes to cbq
From: Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>
Date: Tue, 6 Jul 2004 00:27:27 +0400
Cc: "David S. Miller" <davem@xxxxxxxxxx>, Stephen Hemminger <shemminger@xxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <1088861810.1039.298.camel@xxxxxxxxxxxxxxxx>
References: <1088861810.1039.298.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6i
Hello!

> What i remember is this (4-5 years back) used to cure a bug - cant
> remember the details unfortunately, but Alexey may remember.

Actually, I do not. It looks like an optimization: if the device is
throttled we just do not need to add timer, qdisc will be woken up
by unthrottle. I do not see any race condition here, but also I do not
see why this check could be important.

> At the expense of repeating a discussion that may have already happened,

To be honest, I wish to be reminded. If this check cured something,
it would be interesting to know what was this.

Alexey

<Prev in Thread] Current Thread [Next in Thread>