netdev
[Top] [All Lists]

Re: [XFRM] Convert XFRM_MSG_* macros to an enum

To: herbert@xxxxxxxxxxxxxxxxxxx
Subject: Re: [XFRM] Convert XFRM_MSG_* macros to an enum
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Sat, 03 Jul 2004 19:04:34 +0900 (JST)
Cc: davem@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040703.190042.70899669.yoshfuji@xxxxxxxxxxxxxx>
Organization: USAGI Project
References: <20040703095215.GA16195@xxxxxxxxxxxxxxxxxxx> <20040703.190042.70899669.yoshfuji@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
To clarify:

In article <20040703.190042.70899669.yoshfuji@xxxxxxxxxxxxxx> (at Sat, 03 Jul 
2004 19:00:42 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx> 
says:

> > I've cleaned up the existing MSG definitions by converting them to
> > an enum.  This should make future additions slightly easier in that
> > XFRM_MSG_MAX won't have to be touched again.
:
> Well, I think we'd better to do
> 
>  #define XFRM_MSG_GETSA XFRM_MSG_GETSA
> 
> etc. because this would break (future) applications which do
> #ifdef.

I meant, the change (without #define) would break (future) applications 
which do #ifdef.

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

<Prev in Thread] Current Thread [Next in Thread>