Re: [XFRM] Convert XFRM_MSG_* macros to an enum

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Sat, Jul 03, 2004 at 07:00:42PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> 
> Well, I think we'd better to do
> 
>  #define XFRM_MSG_GETSA XFRM_MSG_GETSA
> 
> etc. because this would break (future) applications which do
> #ifdef.

I think such applications are broken.

They should compile with headers that define these symbols and
test for their support at run-time.

Applications should not detect kernel features at compile-time.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt