netdev
[Top] [All Lists]

Re: [PATCH] (2/4) packet scheduler bad TDIFF_SAFE in csz

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] (2/4) packet scheduler bad TDIFF_SAFE in csz
From: jamal <hadi@xxxxxxxxxx>
Date: 29 Jun 2004 18:43:45 -0400
Cc: shemminger@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040629152822.4fa2e1c4.davem@xxxxxxxxxx>
Organization: jamalopolis
References: <20040629140016.4afeb36b@xxxxxxxxxxxxxxxxxxxxx> <20040629144506.0649d217.davem@xxxxxxxxxx> <1088547756.1040.5.camel@xxxxxxxxxxxxxxxx> <20040629152822.4fa2e1c4.davem@xxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
Sounds like good logic to me.
BTW, that jiffies fix, statemnt from Steve:
> The downside is the overhead of a function call, and a cache miss in >
>get_jiffies_64.

Is this overhead on 32 bit machines or applies on 64 bit as well?
Note that code is used in the fast path.

cheers,
jamal
On Tue, 2004-06-29 at 18:28, David S. Miller wrote:
> On 29 Jun 2004 18:22:37 -0400
> jamal <hadi@xxxxxxxxxx> wrote:
> 
> > That scheduler is only a relic.
> > Nobody uses it ;-> Check the cofig help.
> > Pretty sure if you study it youll find a lot more bugs.
> 
> Right, but it is good that we fix the obvious ones when
> we can.  Stephen's fix resulted in being able to simplify
> some PSCHED_* macros significantly.
> 
> 


<Prev in Thread] Current Thread [Next in Thread>