netdev
[Top] [All Lists]

Re: [PATCH] (2/4) packet scheduler bad TDIFF_SAFE in csz

To: hadi@xxxxxxxxxx
Subject: Re: [PATCH] (2/4) packet scheduler bad TDIFF_SAFE in csz
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Tue, 29 Jun 2004 15:49:07 -0700
Cc: "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <1088549025.1046.12.camel@xxxxxxxxxxxxxxxx>
Organization: Open Source Development Lab
References: <20040629140016.4afeb36b@xxxxxxxxxxxxxxxxxxxxx> <20040629144506.0649d217.davem@xxxxxxxxxx> <1088547756.1040.5.camel@xxxxxxxxxxxxxxxx> <20040629152822.4fa2e1c4.davem@xxxxxxxxxx> <1088549025.1046.12.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On 29 Jun 2004 18:43:45 -0400
jamal <hadi@xxxxxxxxxx> wrote:

> 
> Sounds like good logic to me.
> BTW, that jiffies fix, statemnt from Steve:
> > The downside is the overhead of a function call, and a cache miss in >
> >get_jiffies_64.
> 
> Is this overhead on 32 bit machines or applies on 64 bit as well?
> Note that code is used in the fast path.

jiffies.h

#if (BITS_PER_LONG < 64)
u64 get_jiffies_64(void);
#else
static inline u64 get_jiffies_64(void)
{
        return (u64)jiffies;
}
#endif

<Prev in Thread] Current Thread [Next in Thread>