| To: | Andrew Morton <akpm@xxxxxxxx> |
|---|---|
| Subject: | Re: [NET]: Lockless loopback patch (version 2). |
| From: | Arthur Kepner <akepner@xxxxxxx> |
| Date: | Mon, 21 Jun 2004 08:09:52 -0700 |
| Cc: | netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxx> |
| In-reply-to: | <20040621035702.6114bdbe.akpm@xxxxxxxx> |
| References: | <200406210510.i5L5A340018849@xxxxxxxxxxxxxxx> <20040621035702.6114bdbe.akpm@xxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Mon, 21 Jun 2004, Andrew Morton wrote: > Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> wrote: > > > > [NET]: Lockless loopback patch (version 2). > > The loopback_stats handling looks wrong: > > .... > each get_cpu_ptr() does get_cpu(), which increments preempt_count(). But > there is only a single put_cpu_ptr() in there. > > > Still, I don't see why we need to use alloc_percpu() - why not > statically allocate it? > > This compiles, but does need runtime testing. Thanks, Andrew. I'll do some basic testing of this change and post results (probably by tomorrow.) -- Arthur |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [7/9][PATCH 2.6] Media mode rewrite, Roger Luethi |
|---|---|
| Next by Date: | Re: RFC: [1/2] PPP MPPE module, Christoph Hellwig |
| Previous by Thread: | Re: [NET]: Lockless loopback patch (version 2)., Andrew Morton |
| Next by Thread: | Re: [NET]: Lockless loopback patch (version 2)., David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |