Re: [PATCH 2.6.7-rc3-mm2 2/5] via-velocity: uniformize use of OWNED_BY_NIC

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Jeff Garzik <jgarzik@xxxxxxxxx> :
> Francois Romieu wrote:
[...]
> > +static inline void velocity_give_rx_desc(struct rx_desc *rd)
> > +{
> > +   *(u32 *)&rd->rdesc0 = 0;
> > +   rd->rdesc0.owner = cpu_to_le32(OWNED_BY_NIC);
> > +}
> 
> The patch itself is OK, and I will merge, but I wonder:
> 
> isn't a wmb() needed perhaps?

/me scratches head...

Ok, everything should be fine with a change in velocity_give_many_rx_descs():
[...]
        if (vptr->rd_filled < 4)
                return;

<insert a wmb() here>

        unusable = vptr->rd_filled | 0x0003;


I'll queue that for the next serie.

--
Ueimor