On Wed, 2004-06-16 at 12:49, Jeff Garzik wrote:
> I apologize for not responding earlier...
>
> ethtool is the wrong direction for a few reasons,
> * I really should have done ethtool via netlink
> * We want to move away from pretending that 802.3 == 802.11, and using
> ethtool only serves to reinforce an association we don't want to make.
> "everything is ethernet" isn't really true :)
Ok, then Gertjan was on track with his earlier post introducing
wlantool_ops. Scratch the ethtool idea, my bad.
Gertjan, can we make the wlantool_ops more purpose-specific as Jeff
suggests?
struct wlantool_ops {
int (*commit)(struct net_device *);
void (*get_name)(struct net_device *, struct wlantool_name *);
- int (*get_nwid)(struct net_device *, struct wlantool_param *);
- int (*set_nwid)(struct net_device *, struct wlantool_param *);
+ u16 (*get_nwid)(struct net_device *);
+ void (*set_nwid)(struct net_device *, u16);
int (*get_freq)(struct net_device *, struct wlantool_freq *);
int (*set_freq)(struct net_device *, struct wlantool_freq *);
- int (*get_mode)(struct net_device *, struct wlantool_mode *);
- int (*set_mode)(struct net_device *, struct wlantool_mode *);
- int (*get_sens)(struct net_device *, struct wlantool_param *);
- int (*set_sens)(struct net_device *, struct wlantool_param *);
+ u32 (*get_mode)(struct net_device *);
+ void (*set_mode)(struct net_device *, u32);
+ u16 (*get_sens)(struct net_device *);
+ void (*set_sens)(struct net_device *, u16);
<etc>
};
-scott
|