netdev
[Top] [All Lists]

Re: Allow IP header alignment to be overriden

To: Anton Blanchard <anton@xxxxxxxxx>
Subject: Re: Allow IP header alignment to be overriden
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Tue, 15 Jun 2004 21:37:23 -0700
Cc: sfeldma@xxxxxxxxx, netdev@xxxxxxxxxxx, john.ronciak@xxxxxxxxx, ganesh.venkatesan@xxxxxxxxx, leonid.grossman@xxxxxxxx
In-reply-to: <20040615233423.GC3228@krispykreme>
References: <20040611012727.GA27672@krispykreme> <20040610223549.5e9ad025.davem@xxxxxxxxxx> <1086939562.3657.10.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20040611142336.GE27672@krispykreme> <20040612111218.783f587d.davem@xxxxxxxxxx> <20040615233423.GC3228@krispykreme>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 16 Jun 2004 09:34:23 +1000
Anton Blanchard <anton@xxxxxxxxx> wrote:

> > Yes.  Please add a paragraph to that comment explaining what "unaligned
> > CPU cost" really means, ie. that the IP/TCP header members are going to
> > be accessed with alignment less than the types might require on a given
> > architecture.
> > 
> > Then I'll apply this and we can start beating up the drivers.
> 
> How does this look? The s2io, ixgb and e1000 drivers are converted.

Works for me, applied.

Thanks Anton.

<Prev in Thread] Current Thread [Next in Thread>