netdev
[Top] [All Lists]

Re: Allow IP header alignment to be overriden

To: Anton Blanchard <anton@xxxxxxxxx>
Subject: Re: Allow IP header alignment to be overriden
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 10 Jun 2004 22:35:49 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040611012727.GA27672@krispykreme>
References: <20040611012727.GA27672@krispykreme>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 11 Jun 2004 11:27:27 +1000
Anton Blanchard <anton@xxxxxxxxx> wrote:

> The following patch creates skb_align and allows an architecture to
> override it. Thoughts?

This transformation is not valid for a lot of drivers, that "2"
in the reserve exists elsewhere in other calculations in the
drivers.  For example, it is added to the RX skb allocation
size.  Sometimes this '2' is there in non-trivial or hard to
see ways (ie. it's implicitly in some DMA alignment value)

That's the only reason I'm against this patch.

<Prev in Thread] Current Thread [Next in Thread>