netdev
[Top] [All Lists]

Re: Allow IP header alignment to be overriden

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: Allow IP header alignment to be overriden
From: Anton Blanchard <anton@xxxxxxxxx>
Date: Fri, 11 Jun 2004 11:43:55 +1000
Cc: davem@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040611013522.GA9809@xxxxxxxxxxxxx>
References: <20040611012727.GA27672@krispykreme> <20040611013522.GA9809@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040523i
> > +#ifndef ARCH_HAS_SKB_ALIGN
> > +#define skb_align(SKB, LEN)        skb_reserve((SKB), (LEN))
> > +#endif
> 
> But where does this come from? There's no clear asm/ include in skbuff.h
> matching it, and relying on indirect ones is probably not a good idea.

Yeah I wasnt particularly happy about where I put the override.
skbuff.h directly includes:

#include <asm/atomic.h>
#include <asm/types.h>

...

#include <asm/system.h>

system.h gets included way down in the file, so I picked system.h as the 
most reasonable of the three. Im open to ideas as to how to make this neater.

Anton

<Prev in Thread] Current Thread [Next in Thread>