| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] remove net driver ugliness that sparse complains about |
| From: | viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx |
| Date: | Sat, 29 May 2004 21:44:57 +0100 |
| Cc: | Netdev <netdev@xxxxxxxxxxx>, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, Arjan van de Ven <arjanv@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxx> |
| In-reply-to: | <40B8D2F8.6090905@xxxxxxxxx> |
| References: | <40B8D2F8.6090905@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
On Sat, May 29, 2004 at 02:14:16PM -0400, Jeff Garzik wrote: > I'm a bit curious why sparse complained about taking the _address_ of > pointer, but nonetheless it's an ugliness that should be contained > before it spreads :) Attached is a proposed cleanup patch for comment. > The ugliness is confined to include/linux/mii.h, and I avoid use the > ifru_data field completely. sparse hadn't ;-) I had, when I saw it in grep output. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] remove net driver ugliness that sparse complains about, viro |
|---|---|
| Next by Date: | Re: [PATCH] remove net driver ugliness that sparse complains about, Linus Torvalds |
| Previous by Thread: | Re: [PATCH] remove net driver ugliness that sparse complains about, Jeff Garzik |
| Next by Thread: | net/ipv4/route.c GC patch: is this insane?, Daniel Stone |
| Indexes: | [Date] [Thread] [Top] [All Lists] |