netdev
[Top] [All Lists]

Re: [Prism54-devel] Re: [PATCH 0/14] prism54: bring up to sync with pris

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [Prism54-devel] Re: [PATCH 0/14] prism54: bring up to sync with prism54.org cvs rep
From: Andrew Morton <akpm@xxxxxxxx>
Date: Thu, 27 May 2004 12:05:44 -0700
Cc: schizo@xxxxxxxxxx, mcgrof@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, prism54-devel@xxxxxxxxxxx, debian-kernel@xxxxxxxxxxxxxxxx
In-reply-to: <40B63639.6080705@xxxxxxxxx>
References: <20040524083003.GA3330@xxxxxxxxxxxxxxxxxx> <40B63132.4050906@xxxxxxxxx> <20040527182531.GA8942@xxxxxxxxxxx> <40B63639.6080705@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
>
>  Luis, you, or somebody should create a new patch series with just the 
>  critical fixes, NO WHITESPACE/FORMATTING CHANGES mixed in, and send 
>  those first.

Whitespace changes are often nice, but they should be the very first
patch[es] in the series.  You should be able to verify that the .o file was
unchanged before and after.

That way they become a no-brainer and it becomes easier to review and
understand the substantive changes.

<Prev in Thread] Current Thread [Next in Thread>