|To:||YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>|
|Subject:||Re: [PATCH]Add new IPv6 MIBs counters support through netlink|
|From:||Shirley Ma <xma@xxxxxxxxxx>|
|Date:||Wed, 26 May 2004 16:32:04 -0700|
|Cc:||davem@xxxxxxxxxx, mashirle@xxxxxxxxxx, netdev@xxxxxxxxxxx, "Hideaki YOSHIFUJI" <yoshfuji@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>, yoshfuji@xxxxxxxxxxxxxx|
Thanks for you comments!
> Without adding support for u64 counter, it does not make sense to add
> new interface. You can add new counter to the end of the structures.
It's not good to add new counters to the end of the old structure. The mib
number and offset will be wrong.
>This also contains per-interface statistics support.
(I rember that you said that) we should add idev into an route and avoid
Only a few get/put idev there, not too many. And in some places there are no
route, no we can't use idev in route.
> I strongly do not want to poeple to change their code twice to support
All the counters not just IP will be eventually 64 bits. We can fix it later. And
if we implement 64 counters here, there is performance issue on some
architectures which don't support atmoic 64 for 32 bit platform.
IBM Linux Technology Center
15300 SW Koll Parkway
Beaverton, OR 97006-6063
Phone: (503) 578-7638
FAX: (503) 578-3228
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH]Add new IPv6 MIBs counters support through netlink, David S. Miller|
|Next by Date:||Re: [PATCH]Add new IPv6 MIBs counters support through netlink, Shirley Ma|
|Previous by Thread:||Re: [PATCH]Add new IPv6 MIBs counters support through netlink, Shirley Ma|
|Next by Thread:||Re: [PATCH]Add new IPv6 MIBs counters support through netlink, YOSHIFUJI Hideaki / 吉藤英明|
|Indexes:||[Date] [Thread] [Top] [All Lists]|