netdev
[Top] [All Lists]

[PATCH 2.6] TBF: do not oops when user tries to attach/show filter

To: netdev@xxxxxxxxxxx
Subject: [PATCH 2.6] TBF: do not oops when user tries to attach/show filter
From: Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx>
Date: Tue, 25 May 2004 23:12:37 -0500
Cc: "David S. Miller" <davem@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.6.2
TBF does not allow attaching filters; implement dummy tcf_chain method to
avoid oopsing.

-- 
Dmitry


===================================================================


ChangeSet@xxxxxx, 2004-05-25 22:54:30-05:00, dtor_core@xxxxxxxxxxxxx
  [NET_SCHED] Do not oops when user tries to attach a filter to a TBF qdisc.
              (TBF does not allow attaching filters as it has only one class,
              filter should be attached either to TBF's parent or to its child)


 sch_tbf.c |    6 ++++++
 1 files changed, 6 insertions(+)


===================================================================



diff -Nru a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c
--- a/net/sched/sch_tbf.c       2004-05-25 22:57:37 -05:00
+++ b/net/sched/sch_tbf.c       2004-05-25 22:57:37 -05:00
@@ -495,6 +495,11 @@
        }
 }
 
+static struct tcf_proto **tbf_find_tcf(struct Qdisc *sch, unsigned long cl)
+{
+       return NULL;
+}
+
 static struct Qdisc_class_ops tbf_class_ops =
 {
        .graft          =       tbf_graft,
@@ -504,6 +509,7 @@
        .change         =       tbf_change_class,
        .delete         =       tbf_delete,
        .walk           =       tbf_walk,
+       .tcf_chain      =       tbf_find_tcf,
        .dump           =       tbf_dump_class,
 };
 

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 2.6] TBF: do not oops when user tries to attach/show filter, Dmitry Torokhov <=