netdev
[Top] [All Lists]

Re: Kernel BUG: Qos seg. fault

To: Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx>
Subject: Re: Kernel BUG: Qos seg. fault
From: jamal <hadi@xxxxxxxxxx>
Date: 24 May 2004 18:09:31 -0400
Cc: Jaume Catarineu <jaume.catarineu@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20040524215346.73109.qmail@xxxxxxxxxxxxxxxxxxxxxxx>
Organization: jamalopolis
References: <20040524215346.73109.qmail@xxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 2004-05-24 at 17:53, Dmitry Torokhov wrote:


> It just does... 

you mean just "because" ? ;-> Semantics allow you to do more.

> TBF as far as I understand is a simple rate
> limiting tool for your network link. 

Consider it a scheduler really.

> I implemented the child
> qdisc for TBF so you can change default fifo queue in it to
> SFQ or PRIO. It supposed to be very lightweight. If you need
> something more complex/fancy then you probably want HTB or CBF.

Ok, I thought you were trying to hierachical token buckets. Why coulnt
you go the extra step?
In any case, i agree what you have is a lightweight improvement; but you
could go the next mile.
Your original patch should be sufficient in the case you just want to
stay there.

cheers,
jamal




<Prev in Thread] Current Thread [Next in Thread>