netdev
[Top] [All Lists]

Re: [PATCH 5/14 linux-2.6.7-rc1] prism54: new prism54 kernel compatibili

To: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 5/14 linux-2.6.7-rc1] prism54: new prism54 kernel compatibility
From: Arjan van de Ven <arjanv@xxxxxxxxxx>
Date: Mon, 24 May 2004 10:53:50 +0200
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, prism54-devel@xxxxxxxxxxx
In-reply-to: <20040524083220.GF3330@xxxxxxxxxxxxxxxxxx>
Organization: Red Hat UK
References: <20040524083220.GF3330@xxxxxxxxxxxxxxxxxx>
Reply-to: arjanv@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 2004-05-24 at 10:32, Luis R. Rodriguez wrote:
> 2004-03-20      Margit Schubert-While <margitsw@xxxxxxxxxxx>
> 
> * isl_38xx.[ch], isl_ioctl.c, islpci_dev.[ch], islpci_eth.c
>   islpci_hotplug.c, islpci_mgt.[ch], oid_mgt.c: Adopt new
>   prism54 kernel compatibility.
> 
> * prismcompat.h, prismcompat24.h: New compatibility work


ewwww this makes the driver quite a bit less readable!

for example

-#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0)
-       /* This is 2.6 specific, nicer, shorter, but not in 2.4 yet */
-       DEFINE_WAIT(wait);
-       prepare_to_wait(&priv->reset_done, &wait, TASK_UNINTERRUPTIBLE);
-#else
-       DECLARE_WAITQUEUE(wait, current);
-       set_current_state(TASK_UNINTERRUPTIBLE);
-       add_wait_queue(&priv->reset_done, &wait);
-#endif
+       PRISM_DEFWAITQ(priv->reset_done, wait)

why not just make a DEFINE_WAIT() and prepare_to_wait() macro for 2.4
instead ?? so that you can just have the 2.6 version in the code and do
2.4 compat in a clean header, as opposed to fouling up the entire driver
with it.

Attachment: signature.asc
Description: This is a digitally signed message part

<Prev in Thread] Current Thread [Next in Thread>